-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add plugins system #62
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also adds plugin examples to the `basic` example, which will be removed before merging.
…tic dir paths They were hell for the deployment process, and didn't add any value.
arctic-hen7
added
A-plugins
Area: plugins system
C-enhancement
Category: enhancement
P-medium
Priority: medium
S-in-development
Status: in development
labels
Oct 13, 2021
We can't modify `MutableStore` or `TranslationsManager` yet though. BREAKING CHANGE: `build_app`/`export_app`now take a `&TemplateMap` (`get_templates_vec` abolished)
…om other examples This includes tests.
Note that `PluginData` is now replaced by `Any`.
This is just a change to the version number, but nonetheless needed before we merge this branch back.
Any plugin can now take functional or control actions. Docs still need updating.
These are replaced by the `set_immutable_store` settings action
I'll add the new testing workflow for the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-plugins
Area: plugins system
C-enhancement
Category: enhancement
P-medium
Priority: medium
S-in-development
Status: in development
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for functional and control plugins, albeit with a limited number of actions right now. This doesn't yet include support for CLI instructions, that will come in future (but very likely before v0.3.0). This is missing support for extending Actix Web server configuration due to certain typing/compilation issues with that library, though there's a workaround of a simple replacement character at present, which could be set by functional or control plugins, which is all documented (or rather will be).
As a side note, this does not add support for custom engines (formerly known as type 3 plugins).
Closes #58.